Yet another Hacker News

Better HTTP/1 connection reuse in Go 1.27

302 points allddd 2 days ago 47 comments

jamesponddotco 2 days ago | parent

I can finally retire xhttp.DrainResponseBody[1], which I just learned, wasn’t doing that good of a job anyway.

[1]: https://github.com/cipherdothost/x-go/blob/caa562ded82b8c417...

aleksi 2 days ago | parent

I can finally remove a similar helper that I copied from project to project and from company to company since r60

jamesponddotco 2 days ago | parent

I built that package exactly to stop copying code from project to project.

Not because of the copy itself, since a little copy is better than a little dependency, as they say, but because it was a pain to update everything when I inevitably found a bug in what I copied.

nasretdinov 2 days ago | parent

It sucks that this changes the behaviour under the hood that you previously coukd rely on the fact that closing the response body lets you skip downloading the HTTP body entirely, but I do like the tradeoff here, since it also limits the download time to just 50ms you'd not get overwhelmed if your network can't keep up with all the cancelled HTTP bodies, you'll just wait a little bit of traffic instead.

prussian 2 days ago | parent

At the very end it mentions it won't drain bodies for Connection: close Does this work with reverse proxies? I've had issues with nginx still getting IO errors when my server doesn't consume bodies and bubbling them up as 5xx codes to the client. I believe I've seen this with Firefox as well, where XHR status codes would be 0. Early closing, without consuming body, seems to work as expected with Chrome and curl though.

jerf 2 days ago | parent

Am I missing something or is none of this information documented in net/http itself? This is a surprising implementation of "Close" and should be documented somewhere.

I can attest to the fact this is a Frequently Asked Question among people who are trying to Go as an HTTP client, so even though this feels somewhat icky, I can understand where it is coming from. However, I'm also missing, if I want to slam this connection closed, which is a reasonable thing to want, how do I do that without uselessly draining a socket I don't intend to reuse? Fake the "Connection: close" header into the Response object? Hope I can dig out an underlying socket of some sort under the concrete type of the Body.Response that I can bypass this code with? Seems like there should be a way to do that too.

aleksi 2 days ago | parent

https://pkg.go.dev/net/http#Client.Do

> Note, however, that Transport will automatically try to read a Response Body to EOF asynchronously up to a conservative limit when a Body is closed.

Similar wording appears in a few other places; search for “asynchronously”.

jerf 2 days ago | parent

Oh, good. Not exactly where I expected it but it's there at least.

jchw 2 days ago | parent

I think it is reasonable for it to not be documented directly on Close. Close is arguably too high level for this: for example, on HTTP/2 this doesn't do what you would intend at all, since the request lifecycle is completely untethered from any underlying socket. If you really wanted to slam the connection closed ASAP it does actually seem more logical to grab the underlying connection and directly force it closed, even though this feels uglier since it requires knowing the underlying layers. To me this "Close" is logically from the perspective of the HTTP request itself and if I'm not getting myself confused and misunderstanding it doesn't really close the connection anyways (e.g. if there is no body and the connection is keep-alive'd, this wouldn't close the underlying connection, right?)

0x696C6961 2 days ago | parent

A CloseNow() error method would make sense.

hnav 2 days ago | parent

HTTP libraries in general are tough because HTTP in practice requires understanding of at least DNS and TLS and in a lot of cases L4 networking as well. If you try to target application developers you end up with leaky abstractions (unread H/1 body draining behavior when you don't even know what HTTP version you're using) or a library low level enough that application developers don't know how to use it. See rust's hyper and reqwest as an example of an attempt at that split.

stingraycharles 2 days ago | parent

As someone who once attempted implementing a http library, I can assure you that the protocol itself is at least equally tough as being aware of all the TLS / L4 edge cases.

I’d argue that implementing both TCP and IP from scratch is easier than implementing an HTTP library.

rkuska 2 days ago | parent

Now if you use json’s Decoder you can read a body and still might end up without reused connection - if a response contains a newline.

Decoder only reads X bytes (512? I don’t remember) and if the structure fits into these bytes exactly (and the multiplications of it) the newline leaves hanging there.

I always check for Decoder.More (this drains whitespace) after decoding.

gandreani 2 days ago | parent

Oof, that is an edge case I wasn't aware of at all. Hard to know where it's documented since it's an integration of both those packages

cyphar 2 days ago | parent

This can happen without HTTP, we hit this issue in runc a decade ago[1] -- some container invocations would mysteriously error out with ECONNRESET and if you added a dummy environment variable they would work again.

Turns out that json.Encoder always appends a newline but (as GP said) json.Decoder will not attempt to read it if the JSON is complete at the power-of-two byte boundary (IIRC the buffer doubles for the first few iterations). The extra byte in the pipe when closed then causes reads and writes to go boom. We switched to using json.Marshal because it doesn't output a newline (sadly the encoded form isn't streamed as a result).

I still get twitchy around encoding/json as a result of that experience.

[1]: https://github.com/docker/docker/issues/14203#issuecomment-1...

rkuska 2 days ago | parent

go-gin switched to using Encoder in some minor version and had to switch back too due to the same problem: https://github.com/gin-gonic/gin/issues/2209

hnav 2 days ago | parent

It drains up to 256K unread bytes period, it doesn't just optimize the case of the body not being read at all.

https://cs.opensource.google/go/go/+/refs/tags/go1.27.2:src/...

What it won't do looking at the code is handle streamed responses over transfer-encoding:chunked which means that if the other end is doing

  json.NewEncoder(responseWriter).Encode(&someStruct)

this optimization won't do anything.

hxtk 2 days ago | parent

While it’s convenient, the Decoder isn’t recommended for those use cases precisely because of the edge cases around readers that don’t contain at most one JSON document with no suffixes.

The standard library maintainers recognized this as a problem that there was no “better,” more convenient way to do it and in encoding/json/v2 they have UnmarshalRead for that use case: https://pkg.go.dev/encoding/json/v2#UnmarshalRead

rkuska 2 days ago | parent

We switched to Decoder due to allocations after profiling - we were using the Decoders/Encoders in a pipeline.

Don't believe there was a more convenient way to achieve the same without writing our own Decoders/Encoders.

donatj 2 days ago | parent

> Using HTTP/1 (GODEBUG=http2client=0), calling this function 100 times against index.golang.org takes ~710 milliseconds on Go 1.26 on my machine. On Go 1.27, the same program takes ~150 milliseconds.

Does this mean I need to disable http2 for this to work or is that just a further proof that http2 isn't actually being used?

80fj0348i 2 days ago | parent

HTTP/2 works differently, you can multiplex and prioritize different data over one TCP connection with HTTP/2. But 60-70% of the web is still HTTP/1 IIRC.

giovannibajo1 2 days ago | parent

As explained in the post, you don’t need any of this in HTTP/2, since you get the benefits of connection sharing without having to read the drain connection body by protocol design

MrDOS 2 days ago | parent

Right. Although the article demonstrates the changes by making requests of a public web server, I would imagine this change has been primarily motivated by a desire to reduce overhead and latency on internal communication between microservices, which very often uses unencrypted HTTP/1 traffic.

seki285 2 days ago | parent

Any reason to be still using HTTP/1 in 2026?

trgn 2 days ago | parent

imo, it's obvious for people writing ajax-y web apps, but backend devs need convincing.

afavour 2 days ago | parent

You’re requesting from a third party backend you don’t control?

nasretdinov 2 days ago | parent

If you don't need SSL you can't use HTTP/2 or HTTP/3. It doesn't make sense for externally facing services but sometimes is ok or even unavoidable for local networks

cyberax 2 days ago | parent

You can use HTTP/2 without encryption - it's called `h2c`. It's not technically standards-compliant and browsers don't support it, but it's used a lot for proxy-to-backend communication where traffic goes over localhost and/or over an internal private network.

creatonez 2 days ago | parent

HTTP/2 without encryption is still standards compliant if you initiate the connection with prior knowledge that the protocol is supported. It's upgrading from HTTP/1.1 that isn't supposed to be supported.

But of course, the only scenarios where you have prior knowledge are things like reverse proxies or custom made clients.

hnav 2 days ago | parent

It's mostly the property of servers and clients that you interoperate with that don't speak H/2. There are other situations too like if you run a CDN and you're doing sendfile with kernel TLS, you can do stuff like the below

  sock.write('HTTP/1.1 200 OK\r\ncontent-length: ' + f.size() + '\r\n\r\n')
  sendfile(sock, f)

which wouldn't work with H2/H3. WebSockets are still in practice H/1 only (spec exists but is disabled in browsers). Another aspect is that if you're simply using HTTP as a preamble to 1 large (bidi) pipe, the extra framing and flow control of H/2 is just a performance handicap.

siren2026 2 days ago | parent

believe it or not but Cloudfront only supports HTTP/1 to origin. Some other CDNs as well.

nemothekid 2 days ago | parent

I haven't checked in a while, but I believe nginx does not support http/2 with proxy_pass.

gempir 2 days ago | parent

It is supported now, but only a very basic version of it https://github.com/nginx/nginx/pull/771

fastest963 2 days ago | parent

Yes, because HTTP/2 in Go is significantly slower: https://github.com/golang/go/issues/47840

thorens 1 day ago | parent

I have clients who have mountains of custom made equipment which only speaks plain HTTP/1.0. Some of it has already been in production for over twenty years and is still doing the job.

While those devices stay static development and updates on the software that interfaces them to the rest of the world has not stopped.

gandreani 2 days ago | parent

I find it kind of amusing to consider that the go team didn't commit to implement this automatic connection re-use until they probably encountered in the wild the horrible but correct third iteration of drainAndCloseBody.

1. Suggest drainAndCloseBody // Team: this is reasonable

2. Implement drainAndCloseBodyWithTimer // Team: no problems here

3. then drainAsyncAndCloseBodyWithTimer // Team: a bit wordy but no problem here

4. Someone at google uses 3. with an http/2 connection // Team: this is where we draw the line?

I sympathize with the struggle of following golang's mission to be simple when you consider this common but tricky edge case. Iteration 3 makes sense but by gosh is it ugly ha.

giancarlostoro 2 days ago | parent

I do wonder when they'll add http/3 into the stdlib. Go having simple but powerful / capable out of the box support for http is one of the key things it had that made it get farther than it could have had it not included such a strong OOTB standard library. I feel like it would have still exploded but not quite as quickly, there's just something about building full web apps with no third party packages using only what's out of the box with Go itself, the only other "language" that I ever felt this way with was probably PHP, although Racket might be another, since I don't think I need to go out of my way to setup anything to do web dev with Racket.

zer00eyz 2 days ago | parent

> the only other "language" that I ever felt this way with was probably PHP

I made a lot of money on PHP and more on Golang.

PHP had warts (variable order) but much like go it came with just about everything you wanted.

It isnt just the functionality - it's the fact that both of them had amazing documentation with the functionality. PHP manual was an amazing reference and the "comments" section always had a bit of solid wisdom for ya (and you needed it cause of the warts). Go's manual (and the blog) are such a fine resource that I rarely need to reach further than what it contains.

It's much easier to use what's included when the documentation is accessible and clear.

rob74 2 days ago | parent

There's no reason to talk about PHP in the past tense, it's still around and actively being maintained. Of course, it has fallen out of favor and been replaced mostly with Node et al (which is IMHO a change for the worse, but opinions may differ).

PHP's "batteries included" approach is probably a product of it being launched before package managers became ubiquitous (the PHP package manager Composer was only released in 2012), Go's is a conscious decision.

CharlieDigital 2 days ago | parent

C#? .NET is very much "batteries included" and very rich first party libs.

giancarlostoro 2 days ago | parent

Not really... A lot of it got shifted into NuGET after .NET Core, then with the .NET rebrand that merged Core and Framework... It USED to be OOTB, but that's no longer true. They did this on purpose, so it could be easier to manage and update.

brainzap 2 days ago | parent

you probably find the discussion, they are currently cleaning up http net to prepare for it

s20n 2 days ago | parent

user script for syntax highlighting on go.dev: https://github.com/kdar/go-highlight-userscript/blob/master/...

finalhacker 2 days ago | parent

old bug = new feat...

baalimago 2 days ago | parent

I don't understand why we http/1 is still around. Even worse: updated to encourage more usage.

Huge security issues involved with it, see: https://portswigger.net/research/can-ai-do-novel-security-re...

_ZeD_ 2 days ago | parent

But how often you do ignore the response body? In my case I do call http endpoints to read it

stingraycharles 2 days ago | parent

And use HEAD if you only care about the response code.

It seems like an edge problem for an edge use case, but I guess At Go’s scale, it’s probably important.